fix(mdx): add .sx props to Themed.X styles #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5567e4c:
|
lachlanjc
approved these changes
Jul 29, 2022
This was referenced Aug 12, 2022
This was referenced Sep 12, 2022
|
🚀 PR was released in |
hasparus
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So,
sxprop in Themed.X components now is an undocumented and untested feature that works in JavaScript, but not TypeScript.While I'm still not sure if Themed.X is the best way to use Theme UI, it's quite easy to fix this discrepancy and close #1350.
📦 Published PR as canary version:
0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0✨ Test out this PR locally via:
npm install @theme-ui/color-modes@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/color@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/components@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/core@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/css@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/custom-properties@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/editor@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install gatsby-plugin-theme-ui@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install gatsby-theme-style-guide@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install gatsby-theme-ui-layout@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/match-media@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/mdx@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/parse-props@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-base@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-bootstrap@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-bulma@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-dark@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-deep@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-funk@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-future@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-polaris@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-roboto@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-sketchy@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-swiss@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-system@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-tailwind@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/preset-tosh@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/presets@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/prism@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/sidenav@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/style-guide@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/tailwind@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/theme-provider@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install theme-ui@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 npm install @theme-ui/typography@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 # or yarn add @theme-ui/color-modes@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/color@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/components@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/core@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/css@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/custom-properties@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/editor@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add gatsby-plugin-theme-ui@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add gatsby-theme-style-guide@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add gatsby-theme-ui-layout@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/match-media@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/mdx@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/parse-props@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-base@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-bootstrap@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-bulma@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-dark@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-deep@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-funk@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-future@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-polaris@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-roboto@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-sketchy@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-swiss@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-system@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-tailwind@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/preset-tosh@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/presets@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/prism@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/sidenav@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/style-guide@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/tailwind@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/theme-provider@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add theme-ui@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0 yarn add @theme-ui/typography@0.15.0--canary.2250.a5dfac6ee7342fb74c68b915d82541eea905f5a7.0Version
Published prerelease version:
v0.15.0-develop.14Changelog
🎉 This release contains work from new contributors! 🎉
Thanks for all your work!
❤️ Luke Watts (@thisislawatts)
❤️ Valto (@pointlessrapunzel)
Release Notes
Drop support for React 16 + 17 (#2215)
Theme UI 0.15.0 drops support for React 16 and React 17. Your use case may still work, but we don't guarantee it.
🚀 Enhancement
@theme-ui/color-modes,@theme-ui/components,@theme-ui/core,@theme-ui/editor,gatsby-plugin-theme-ui,gatsby-theme-style-guide,gatsby-theme-ui-layout,@theme-ui/match-media,@theme-ui/mdx,@theme-ui/parse-props,@theme-ui/preset-base,@theme-ui/preset-bootstrap,@theme-ui/preset-bulma,@theme-ui/preset-dark,@theme-ui/preset-deep,@theme-ui/preset-funk,@theme-ui/preset-polaris,@theme-ui/preset-roboto,@theme-ui/preset-swiss,@theme-ui/preset-system,@theme-ui/preset-tailwind,@theme-ui/preset-tosh,@theme-ui/prism,@theme-ui/sidenav,@theme-ui/style-guide,@theme-ui/theme-provider,theme-ui🐛 Bug Fix
@theme-ui/mdx👨💻 Minor changes
theme-ui🏠 Internal
Authors: 4