Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify MDX React version #2233

Merged
merged 1 commit into from
May 16, 2022

Conversation

pointlessrapunzel
Copy link
Contributor

It has been changed in the README and the Gatsby Getting Started page, but not in the main Getting Started page, so this fixes it.

@vercel
Copy link

vercel bot commented May 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
theme-ui ✅ Ready (Inspect) Visit Preview May 16, 2022 at 2:46PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 12014f1:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

@lachlanjc
Copy link
Member

Thank you!

@pointlessrapunzel pointlessrapunzel deleted the patch-1 branch May 18, 2022 07:13
@nicobrinkkemper
Copy link

Just FYI, mdx@1 will not work with React 18 out of the box

Found: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^16.13.1 || ^17.0.0" from @mdx-js/react@1.6.22

@hasparus
Copy link
Member

Just FYI, mdx@1 will not work with React 18 out of the box

Found: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^16.13.1 || ^17.0.0" from @mdx-js/react@1.6.22

Did you encounter any problems apart from the peer dependency warning?

@nicobrinkkemper
Copy link

nicobrinkkemper commented May 22, 2022

Did you encounter any problems apart from the peer dependency warning?

I'm not too sure if I use the MDX functionality, but so far it works. I used the override property in package.json to mitigate the error/warning.

@hasparus
Copy link
Member

🚀 PR was released in v0.15.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants