Apply bidirectional queue design to the input system #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjian85
force-pushed
the
master
branch
3 times, most recently
from
becd6c7 to
4f4b29a
Compare
jserv
reviewed
Sep 29, 2022
jserv
reviewed
Sep 29, 2022
jserv
reviewed
Sep 30, 2022
jserv
reviewed
Oct 1, 2022
jserv
reviewed
Oct 1, 2022
jserv
reviewed
Oct 1, 2022
alanjian85
force-pushed
the
master
branch
3 times, most recently
from
7f07cec to
22ff138
Compare
|
This pull request introduces 1 alert when merging 22ff138 into 93952a1 - view on LGTM.com new alerts:
|
jserv
reviewed
Oct 2, 2022
jserv
reviewed
Oct 2, 2022
jserv
reviewed
Oct 2, 2022
|
This pull request introduces 1 alert when merging 084c700 into 93952a1 - view on LGTM.com new alerts:
|
jserv
reviewed
Oct 2, 2022
jserv
reviewed
Oct 2, 2022
This commit splits the input system into two parts, event and submission, and introduces two system calls, setup_queue and submit, the former is used to assist in the creation of queues, which is part of the communication bridge between the user application code and the emulator, and the latter is used to notify the emulator that a submission (or a command) should be processed. The design of these system calls is heavily based on Linux io_uring interface.
|
Thank @alanjian85 for contributing! |
|
This pull request introduces 1 alert when merging db8620e into 93952a1 - view on LGTM.com new alerts:
|
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Apply bidirectional queue design to the input system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits the input system into two parts, event and submission, and introduces two system calls, setup_queue and submit, the former is used to assist in the creation of queues, which is part of the communication bridge between the user application code and the emulator, and the latter is used to notify the emulator that a submission (or a command) should be processed. The design of these system calls is heavily based on Linux io_uring interface.