refactor: collapse io and serializer into single class #30
Conversation
| a: null | ||
| ? !!python/object/apply:builtins.frozenset | ||
| - - nested, set | ||
| : null | ||
| is: null |
There was a problem hiding this comment.
yaml should be sorting the keys in alphabetical order, so having "tihs" and "is" after "a" is correct. Perhaps an issue with different pyaml versions, or a limitation of "set"?
There was a problem hiding this comment.
Not sure why this is happening. Also thought I fixed the issue where it tries to rewrite existing passing snapshots
There was a problem hiding this comment.
I actually deleted this file and reran update snapshots
| @@ -1,5 +1,52 @@ | |||
| from typing import Any, Set, Optional | |||
There was a problem hiding this comment.
copy & pasted and then swapped "io" for "serializer". If I split this into 2 commits, maybe GitHub would pick up the diff better?
There was a problem hiding this comment.
That's annoying. I think it's just the fact that this file existed before, so it does not register it as a move/rename
| @@ -91,12 +78,11 @@ def __eq__(self, other) -> bool: | |||
| def _assert(self, data) -> bool: | |||
| self._session.register_assertion(self) | |||
| try: | |||
| serialized_data = self.serializer.encode(data) | |||
There was a problem hiding this comment.
I think we mistakenly reverted the checking without deserializing in this PR 🤦♂
So far we haven't found a use case for separating IO and Serializer logic. I think we can simplify this if we collapse it into a single "serializer".