Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare snapshots without deserializing #21

Closed
iamogbz opened this issue Dec 6, 2019 · 2 comments · Fixed by #26
Closed

Compare snapshots without deserializing #21

iamogbz opened this issue Dec 6, 2019 · 2 comments · Fixed by #26
Assignees
Milestone

Comments

@iamogbz
Copy link
Collaborator

iamogbz commented Dec 6, 2019

Is your feature request related to a problem? Please describe.

Snapshots are currently deserialized into python objects before comparison is done, this is unnecessary

Describe the solution you'd like

No deserialization is done and comparison is done on the serialized representation

Describe alternatives you've considered

N/A

Additional context

Unlocks using yaml.dumps in place of yaml.safe_dumps because loading yaml data is needless

@iamogbz
Copy link
Collaborator Author

iamogbz commented Dec 21, 2019

It was never properly fixed and then subsequently reverted in #30

@iamogbz iamogbz reopened this Dec 21, 2019
@noahnu
Copy link
Collaborator

noahnu commented Dec 21, 2019

For the yaml serializer, can we grab test names out of the file without using unsafe yaml loader?

@noahnu noahnu self-assigned this Dec 22, 2019
noahnu added a commit that referenced this issue Dec 22, 2019
fix: compare serialized snapshots, close #21
@noahnu noahnu closed this as completed in 5bef286 Dec 24, 2019
@noahnu noahnu added this to the v1.0.0 milestone Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants