Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigProfilesUrlAction now shadows UrlAction by default #393

Merged
merged 1 commit into from
May 11, 2022

Conversation

synfinatic
Copy link
Owner

stop using clip as the default, instead use UrlAction
(if valid). Else, default to 'open'

Fixes: #387

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #393 (1f1296a) into main (7871041) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   77.39%   77.47%   +0.08%     
==========================================
  Files          21       21              
  Lines        2517     2526       +9     
==========================================
+ Hits         1948     1957       +9     
  Misses        496      496              
  Partials       73       73              
Impacted Files Coverage Δ
internal/utils/url.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7871041...1f1296a. Read the comment docs.

@synfinatic synfinatic force-pushed the config-url-action branch from 2a7be34 to 0c61fe6 Compare May 11, 2022 16:12
pesudo-randomize color/icon if not set
@synfinatic synfinatic force-pushed the config-url-action branch from 0c61fe6 to 1f1296a Compare May 11, 2022 16:15
@synfinatic synfinatic merged commit a7904de into main May 11, 2022
@synfinatic synfinatic deleted the config-url-action branch May 11, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default value of ConfigProfilesUrlAction in config
1 participant