Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default value of ConfigProfilesUrlAction in config #387

Closed
synfinatic opened this issue May 10, 2022 · 0 comments · Fixed by #393
Closed

Change default value of ConfigProfilesUrlAction in config #387

synfinatic opened this issue May 10, 2022 · 0 comments · Fixed by #393
Labels
bug Something isn't working
Milestone
1.9.2

Comments

@synfinatic
Copy link
Owner

The default is clip, which is really the worst option. should be the same as UrlAction
@synfinatic synfinatic added the bug Something isn't working label May 10, 2022
@synfinatic synfinatic added this to the 1.9.2 milestone May 10, 2022
synfinatic added a commit that referenced this issue May 11, 2022
@synfinatic
ConfigProfilesUrlAction now shadows UrlAction by default
2a7be34 
stop using clip as the default, instead use UrlAction
(if valid).  Else, default to 'open'

Fixes: #387
@synfinatic synfinatic mentioned this issue May 11, 2022
Merged
synfinatic added a commit that referenced this issue May 11, 2022
@synfinatic
ConfigProfilesUrlAction now shadows UrlAction by default
0c61fe6 
stop using clip as the default, instead use UrlAction
(if valid).  Else, default to 'open'

Fixes: #387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.9.2
Development

Successfully merging a pull request may close this issue.

ConfigProfilesUrlAction now shadows UrlAction by default synfinatic/aws-sso-cli
1 participant
@synfinatic