5177 change echo and print in examples #5285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 23, 2015 11:09
Conflicts: book/doctrine.rst components/event_dispatcher/introduction.rst components/serializer.rst
Conflicts: book/doctrine.rst components/event_dispatcher/introduction.rst components/serializer.rst
|
Hey Henry! I'm 👎 on this, mostly because we can't use In the framework, @snoek09 can you change the dump()'s in the components to var_dump()? And then add die statements into the framework stuff? Thanks! |
|
And to be more clear - the |
|
@weaverryan that makes perfect sense. Thanks for clearing that up. |
|
Created a new PR as I deleted my fork: #5388 |
wouterj
added a commit
that referenced
this pull request
Jun 27, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [#5388] change echo and print in examples This is a split of #5388 for the 2.3 branch. Original description: > | Q | A > | ------------- | --- > | Doc fix? | yes > | New docs? | no > | Applies to | all > | Fixed tickets | #5177 > > Original PR and discussion in #5285 > > Change echo/print in examples to use: > > - `var_dump()` in components docs > - `dump()` in framework docs Commits ------- 37db975 5177 use var_dump() in components 9fa1c11 5177 use var_dump() in components c2acbee 5177 add die() after dump() 78c9b7c 5177 use dump() instead of print in examples 10898c9 5177 use dump() instead of echo in examples
wouterj
added a commit
that referenced
this pull request
Jun 27, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [#5388] change echo and print in examples A split of #5388 for the changes in the 2.6 branch. Original description: > | Q | A > | ------------- | --- > | Doc fix? | yes > | New docs? | no > | Applies to | all > | Fixed tickets | #5177 > > Original PR and discussion in #5285 > > Change echo/print in examples to use: > > - `var_dump()` in components docs > - `dump()` in framework docs Commits ------- 5c63064 5177 fix leftover dump() ac4e02e 5177 use var_dump() in components 00a522b 5177 use dump() instead of echo in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change echo/print in examples to use dump().