Changing echo/print in examples to use (var_)dump #5177
Labels
actionable
Clear and specific issues ready for anyone to take them.
good first issue
Ideal for your first contribution! (some Symfony experience may be required)
hasPR
A Pull Request has already been submitted for this issue.
Comments
|
Actually, why don't we remove the echo and just use |
|
It's an option, but might not apply to all output-using examples. For this page it might be nicer to indeed use a comment. |
wouterj
added
good first issue
wouterj
added
the
hasPR
wouterj
added a commit
that referenced
this issue
Jun 27, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [#5388] change echo and print in examples This is a split of #5388 for the 2.3 branch. Original description: > | Q | A > | ------------- | --- > | Doc fix? | yes > | New docs? | no > | Applies to | all > | Fixed tickets | #5177 > > Original PR and discussion in #5285 > > Change echo/print in examples to use: > > - `var_dump()` in components docs > - `dump()` in framework docs Commits ------- 37db975 5177 use var_dump() in components 9fa1c11 5177 use var_dump() in components c2acbee 5177 add die() after dump() 78c9b7c 5177 use dump() instead of print in examples 10898c9 5177 use dump() instead of echo in examples
wouterj
added a commit
that referenced
this issue
Jun 27, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [#5388] change echo and print in examples A split of #5388 for the changes in the 2.6 branch. Original description: > | Q | A > | ------------- | --- > | Doc fix? | yes > | New docs? | no > | Applies to | all > | Fixed tickets | #5177 > > Original PR and discussion in #5285 > > Change echo/print in examples to use: > > - `var_dump()` in components docs > - `dump()` in framework docs Commits ------- 5c63064 5177 fix leftover dump() ac4e02e 5177 use var_dump() in components 00a522b 5177 use dump() instead of echo in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think the code should be looked through and see if usages of echo and print can be limited. I think the best replacement could be a reference to
dump()to output data, but avar_dump()could be sufficient too, depending on whether it's framework or a component documentation. An example of usingechocan be found on /components/event_dispatcher/introduction.html#event-name-introspectionThe text was updated successfully, but these errors were encountered: