Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WCM] Documented deprecation of the apache router. #3446

Merged
merged 1 commit into from
Jan 21, 2014
Merged

[WCM] Documented deprecation of the apache router. #3446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cookbook/configuration/apache_router.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ How to use the Apache Router
Symfony2, while fast out of the box, also provides various ways to increase that speed with a little bit of tweaking.
One of these ways is by letting Apache handle routes directly, rather than using Symfony2 for this task.

.. note::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we used a .. caution for all other deprecation messages, let's use it here too to be consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but I checked before adding it here, and the one I found used a .. note ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could remeber where you found it. So we can change that. :)


Apache router was deprecated in Symfony 2.5 and will be removed in Symfony 3.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should wrap lines after the first word that crosses the 72nd character, even if this isn't done properly in the rest of this document (you can change that as well if you like to).

Since the PHP implementation of the Router was improved, performance gains were no longer
significant (while it's very hard to replicate the same behaviour).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behavior

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both versions are valid and both are used in the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agreed on using AE in the docs. So, we should then change the other occurences of behaviour if there are any.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a pull request (#3451 ) for the things I found.


Change Router Configuration Parameters
--------------------------------------

Expand Down