Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some language tweaks (AE, third-person perspective) #3451

Merged
merged 1 commit into from
Jan 22, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 9, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@@ -281,7 +281,7 @@ Submitting Forms with Multiple Buttons

When your form contains more than one submit button, you will want to check
which of the buttons was clicked to adapt the program flow in your controller.
Let's add a second button with the caption "Save and add" to our form::
To do this add a second button with the caption "Save and add" to your form::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To do this,

@weaverryan
Copy link
Member

Wow, very very complete and big job @xabbuh - nice work finding so many things! I'm ready to merge after the tweaks I just mentioned.

Thanks!

@xabbuh
Copy link
Member Author

xabbuh commented Jan 21, 2014

Thank you very much for your detailed review @weaverryan.

@weaverryan
Copy link
Member

No, thank you @xabbuh ;)

weaverryan added a commit that referenced this pull request Jan 22, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

some language tweaks (AE, third-person perspective)

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

0aad5d3 some language tweaks (AE, third-person perspective)
@weaverryan weaverryan merged commit 0aad5d3 into symfony:2.3 Jan 22, 2014
@xabbuh xabbuh deleted the language-tweaks branch January 22, 2014 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants