Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:entity] confirm to allow non-ascii char's in entity names #1496

Merged
merged 4 commits into from
May 19, 2024

Conversation

Fan2Shrek
Copy link
Contributor

@Fan2Shrek Fan2Shrek commented Mar 30, 2024

Following the message #1474 (comment), I made some modifications


edited by @jrushlow
fixes #1556

@Fan2Shrek Fan2Shrek force-pushed the better-accent-prevention branch 2 times, most recently from 749f523 to 8c49009 Compare March 30, 2024 20:55
@Fan2Shrek Fan2Shrek changed the title Update bad entity name management [Make:Entity] Update bad entity name management Mar 30, 2024
@jrushlow jrushlow added this to the v1.60.0 milestone May 6, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Fan2Shrek - I've suggested a couple minor changes which I'll go ahead and commit so we can merge.

src/Maker/MakeEntity.php Outdated Show resolved Hide resolved
src/Maker/MakeEntity.php Outdated Show resolved Hide resolved
@jrushlow jrushlow changed the title [Make:Entity] Update bad entity name management [make:entity] confirm to allow non-ascii char's in entity names May 19, 2024
@jrushlow jrushlow added Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer labels May 19, 2024
@jrushlow jrushlow merged commit 957aab4 into symfony:main May 19, 2024
7 checks passed
@Fan2Shrek Fan2Shrek deleted the better-accent-prevention branch May 19, 2024 09:34
@jrushlow jrushlow mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[make:entity] Entity Names Should Be Allowed to Have Digits (i.e. v1)
2 participants