Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:entity] Entity Names Should Be Allowed to Have Digits (i.e. v1) #1556

Closed
jakeschroeder-fountaindigital opened this issue May 7, 2024 · 1 comment · Fixed by #1496
Closed
Labels

Comments

@jakeschroeder-fountaindigital
Copy link

jakeschroeder-fountaindigital commented May 7, 2024

Steps to reproduce:

  • Use make:entity with a namespaced classname that includes a digit (i.e., Foo\v1\Bar)
  • Observe ASCII error

return preg_match('/^[a-zA-Z\\\\]+$/', $entityName);

Replace regex in line 832
Old = ^[a-zA-Z\\\\]+$
New = ^[a-zA-Z\\\d]+$

Removes duplicated \ (escaped "") and adds digit as allowable character.

@Sayanel34
Copy link

I went from 1.39 to 1.59 and experienced this.
I went down to 1.56 for now and it works again without this error.
Hope it will get fixed, we still need number in namespace for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants