drop PHP 7.x support #1122
Merged
drop PHP 7.x support #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
commented
May 18, 2022
Comment on lines
146
to
150
| public function isDoctrineSupportingAttributes(): bool | ||
| { | ||
| return $this->isDoctrineInstalled() && $this->attributeMappingSupport && $this->phpCompatUtil->canUseAttributes(); | ||
| return $this->isDoctrineInstalled() && $this->attributeMappingSupport; | ||
| } | ||
|
|
There was a problem hiding this comment.
We will handle bringing doctrine related makers up to PHP8 standards in a separate PR to avoid too much bloat in this one.
jrushlow
commented
May 18, 2022
Comment on lines
872
to
-883
| /** @legacy Drop when Annotations are no longer supported */ | ||
| private function doesEntityUseAttributeMapping(string $className): bool | ||
| { | ||
| if (!$this->phpCompatUtil->canUseAttributes()) { | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Handled under a separate PR dedicated to doctrine.
jrushlow
added
Status: Needs Review
weaverryan
approved these changes
May 18, 2022
appveyor.yml
Outdated
| @@ -27,7 +27,7 @@ environment: | |||
| TEST_DATABASE_DSN: mysql://root:Password12!@127.0.0.1:3306/test_maker | |||
| matrix: | |||
| - dependencies: highest | |||
| php_ver_target: 7.2.5 | |||
| php_ver_target: 8.0.0 | |||
There was a problem hiding this comment.
Tests failing, looks like we may need to bump this to 8.0.SOMETHING that actually works, which is fine.
jrushlow
added
Status: Reviewed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpCompatUtil::class- that will be handled under a separate PR.