BC break since removing PHP7 support

[aschempp]

Not sure if this bundle is following semantic versioning, or what is considered API. But removing methods from PhpCompatUtil in #1122 causes a BC break of our custom maker bundle (see contao/contao#5051). Is there no semver here or is this not considered API?

/cc @jrushlow

[jrushlow]

Howdy @aschempp - We do follow Semantic Versioning through Symfony's Backward Compatibility Promise. See https://github.com/symfony/maker-bundle#backwards-compatibility-promise

However, the PhpCompatUtil is marked as internal and is not apart of the public API, changes may be made that will break libraries that use the utility outside of maker bundle. This concept applies to any file within this bundle (and even Symfony) that is maked with the @internal annotation.

maker-bundle/src/Util/PhpCompatUtil.php

Line 19 in e88dde4

* @internal

I can't remember which, but i believe PHPUnit and/or Psalm have checks that can be used to detect if a library is directly using an internal class.

[aschempp]

Thanks @jrushlow, I didn't notice the @internal flag. Then it's clearly a problem on our end 😊