Upgrade to Symfony 6.1 #1339

javiereguiluz · 2022-05-12T14:29:54Z

Don't mind much about the sanitize_html Twig filter. I added it quickly to make the application work. We're discussing about how adding again this Twig filter in the Symfony HtmlSanitizer component.

These are the remaining deprecations:

Remaining indirect deprecation notices (6)

  1x: The "DAMA\DoctrineTestBundle\Doctrine\DBAL\StaticDriver" class implements "Doctrine\DBAL\VersionAwarePlatformDriver" that is deprecated All drivers will have to be aware of the server version in the next major release.
    1x in PHPUnitExtension::executeBeforeFirstTest from DAMA\DoctrineTestBundle\PHPUnit

  1x: The "Symfony\Bridge\Doctrine\Logger\DbalLogger" class implements "Doctrine\DBAL\Logging\SQLLogger" that is deprecated Use {@see \Doctrine\DBAL\Logging\Middleware} or implement {@see \Doctrine\DBAL\Driver\Middleware} instead.
    1x in AddUserCommandTest::testCreateUserNonInteractive from App\Tests\Command

  1x: Method "ArrayAccess::offsetExists()" might add "bool" as a native return type declaration in the future. Do the same in implementation "Dflydev\DotAccessData\Data" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in BlogControllerTest::testAdminShowPost from App\Tests\Controller\Admin

  1x: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Dflydev\DotAccessData\Data" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in BlogControllerTest::testAdminShowPost from App\Tests\Controller\Admin

  1x: Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "Dflydev\DotAccessData\Data" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in BlogControllerTest::testAdminShowPost from App\Tests\Controller\Admin

  1x: Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "Dflydev\DotAccessData\Data" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in BlogControllerTest::testAdminShowPost from App\Tests\Controller\Admin

@dmaicher do you know how can we remove the deprecation notice about DoctrineTestBundle? Thanks!

@derrabus do you know how can we fix the deprecation about Symfony\Bridge\Doctrine\Logger\DbalLogger? Thanks!

stof · 2022-05-12T15:13:31Z

For the DbalLogger, the work is in progress at doctrine/DoctrineBundle#1517

stof · 2022-05-12T15:15:31Z

src/Twig/AppExtension.php

+
+    public function sanitize(string $unsafeHtmlContents): string
+    {
+        $htmlSanitizer = new HtmlSanitizer((new HtmlSanitizerConfig())->allowSafeElements());


you should rather showcase using the service configured by FrameworkBundle (by injecting the HtmlSanitizerInterface)

Yes ... but HtmlSanitizer component will probably add the Twig extension again ... so we'll remove ours. Let's wait a bit before doing any change. Thanks!

dmaicher · 2022-05-13T06:52:29Z

@javiereguiluz regarding

  1x: The "DAMA\DoctrineTestBundle\Doctrine\DBAL\StaticDriver" class implements "Doctrine\DBAL\VersionAwarePlatformDriver" that is deprecated All drivers will have to be aware of the server version in the next major release.
    1x in PHPUnitExtension::executeBeforeFirstTest from DAMA\DoctrineTestBundle\PHPUnit

unfortunately there is no way to fix this deprecation 😕 Also see dmaicher/doctrine-test-bundle#188 (comment)

javiereguiluz · 2022-05-13T07:20:28Z

@dmaicher thanks a lot for your reply. However, I'm afraid I don't understand this well:

unfortunately there is no way to fix this deprecation

You mean that this can't be fixed in DoctrineTestBundle and need to be fixed somewhere else (e.g. Doctrine DBAL) or you really mean that it cannot be fixed in any way. Thanks!

dmaicher · 2022-05-13T07:36:19Z

There is no way currently to get rid of this deprecation because of DBAL. The VersionAwarePlatformDriver interface is deprecated but still needs to be implemented. There is no forward compatibility layer on DBAL so that it works without implementing the interface.

So I don't see any way of fixing this unless maybe there is a forward compatibility path on DBAL itself that would allow not implementing the interface.

javiereguiluz · 2022-05-13T07:43:41Z

@dmaicher I see. Thanks for explaining this in detail. Maybe @stof knows people in the Doctrine organization or, specifically, the DBAL project that could take a look about this. Thanks!

javiereguiluz · 2022-05-27T10:37:36Z

I've deleted the custom sanitize_html Twig filter to use the filter with the same name provided by HtmlSanitizer component (it was added here: symfony/symfony#46335)

But, I'm seeing this error:

Any clue? Thanks!

…er services (nicolas-grekas) This PR was merged into the 6.1 branch. Discussion ---------- [FrameworkBundle][TwigBundle] Fix registering html-sanitizer services | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | symfony/demo#1339 (comment) | License | MIT | Doc PR | - Commits ------- 9876f2f [FrameworkBundle][TwigBundle] Fix registering html-sanitizer services

94noni · 2022-06-18T09:45:13Z

composer.json

    },
    "require": {
-        "php": ">=8.0.2",
+        "php": ">=8.1",


do not forget the readme file's requirements :)

javiereguiluz · 2022-06-21T13:03:38Z

Can anybody please help me? I can't make the HTML sanitizer work. Instead of sanitizing, it just removes everything. I'm reading https://symfony.com/doc/current/html_sanitizer.html but I can't find the cause of the bug. Thanks!

Fixed! The html_sanitizer.yaml config file wasn't being processed by Symfony on my local machine for unknown reasons. I deleted the cache and then it worked.

94noni · 2022-06-21T14:13:37Z

composer.json

@@ -9,10 +9,11 @@
        "symfony/polyfill-php72": "*",
        "symfony/polyfill-php73": "*",
        "symfony/polyfill-php74": "*",
-        "symfony/polyfill-php80": "*"
+        "symfony/polyfill-php80": "*",


both can be removed as now the php version is forced via the require

I'm not sure ... all these are in the replace section of composer.json. If I'm right, listing them here means that Composer won't download those packages even if some dependency requires them. So, the idea is that you add new polyfills when you upgrade your minimum required PHP version.

ho right! I did not pay attention where the location were at first :s my bad

this is indeed the list of polyfills that are replaced by the project platform requirements. So they should be added, not removed.

stof reviewed May 12, 2022

View reviewed changes

javiereguiluz force-pushed the sf61 branch from 75e7846 to 61c10e6 Compare May 14, 2022 10:04

nicolas-grekas mentioned this pull request May 27, 2022

[FrameworkBundle][TwigBundle] Fix registering html-sanitizer services symfony/symfony#46480

Merged

stof mentioned this pull request Jun 14, 2022

Fix issues reported by PHPStan #1334

Closed

94noni reviewed Jun 18, 2022

View reviewed changes

94noni approved these changes Jun 18, 2022

View reviewed changes

94noni reviewed Jun 21, 2022

View reviewed changes

94noni approved these changes Jun 21, 2022

View reviewed changes

Upgrade to Symfony 6.1

e79b100

javiereguiluz force-pushed the sf61 branch from 08c50b2 to e79b100 Compare June 21, 2022 15:11

javiereguiluz merged commit 096896f into symfony:main Jun 21, 2022

javiereguiluz deleted the sf61 branch June 21, 2022 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Symfony 6.1 #1339

Upgrade to Symfony 6.1 #1339

javiereguiluz commented May 12, 2022

stof commented May 12, 2022

stof May 12, 2022

javiereguiluz May 12, 2022 •

edited

Loading

dmaicher commented May 13, 2022

javiereguiluz commented May 13, 2022

dmaicher commented May 13, 2022

javiereguiluz commented May 13, 2022

javiereguiluz commented May 27, 2022

94noni Jun 18, 2022

javiereguiluz commented Jun 21, 2022 •

edited

Loading

94noni Jun 21, 2022

javiereguiluz Jun 21, 2022

94noni Jun 21, 2022

stof Jun 21, 2022

Upgrade to Symfony 6.1 #1339

Upgrade to Symfony 6.1 #1339

Conversation

javiereguiluz commented May 12, 2022

stof commented May 12, 2022

stof May 12, 2022

Choose a reason for hiding this comment

javiereguiluz May 12, 2022 • edited Loading

Choose a reason for hiding this comment

dmaicher commented May 13, 2022

javiereguiluz commented May 13, 2022

dmaicher commented May 13, 2022

javiereguiluz commented May 13, 2022

javiereguiluz commented May 27, 2022

94noni Jun 18, 2022

Choose a reason for hiding this comment

javiereguiluz commented Jun 21, 2022 • edited Loading

94noni Jun 21, 2022

Choose a reason for hiding this comment

javiereguiluz Jun 21, 2022

Choose a reason for hiding this comment

94noni Jun 21, 2022

Choose a reason for hiding this comment

stof Jun 21, 2022

Choose a reason for hiding this comment

javiereguiluz May 12, 2022 •

edited

Loading

javiereguiluz commented Jun 21, 2022 •

edited

Loading