Replace DbalLogger by DebugMiddleware

[l-vo]

Fixes #1431

[l-vo]

@stof PR updated according to your feedbacks 🙂

[l-vo]

@stof Feedbacks answered :)

[dmaicher]

I think this should go to 2.7.x, or? Not sure this qualifies as a patch?

[ostrolucky]

indeed

[l-vo]

I targeted 2.6 because on the Symfony side, the choice was to pass middlewares adds in a patch version to fix the deprecation about DebugStack. But maybe here the case is a bit different... It's up to you to choose 🙂

[l-vo]

@dmaicher @ostrolucky So given my explanation #1517 (comment) should I target 2.7 instead ?

[dmaicher]

@l-vo I just tested this on one of my apps and it looks like for me its not working as intended.

with DoctrineBundle 2.6.3:

With your changes on 2.7.x and the same page:

Did you test this on a real app?

[l-vo]

@dmaicher Yes, I tested on a real app, which version of the doctrine bridge and dbal do you use ?

[dmaicher]

@dmaicher Yes, I tested on a real app, which version of the doctrine bridge and dbal do you use ?

I'm using those

doctrine/dbal                            3.3.6                    Powerful PHP database abstraction layer (DBAL) with many features for database schema introspection and management.
symfony/doctrine-bridge                  v5.4.9                   Provides integration for Doctrine with various Symfony components

[l-vo]

It works on b700275 (after #1488) for me, could you try this commit on your project ? Maybe a bad conflict resolution has broken the system ?

[l-vo]

It works on b700275 (after #1488) for me, could you try this commit on your project ? Maybe a bad conflict resolution has broken the system ?

My bad, I didn't look the good commit; indeed; there is a problem, I'll take a look.

[l-vo]

@dmaicher I don't understand how it occurred, but it seems the dbal.xml file hasn't been pushed. Fix in #1535.