fix: server side pagination #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set offset to 0 when rows are changed so that you can show data loaded from the server for the second page. Reverts swimlane#516
9 tasks
rsparrow
pushed a commit
to rsparrow/ngx-datatable
that referenced
this pull request
Jun 2, 2017
fix: server side pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set offset to 0 when rows are changed so that you can show data loaded from the server for the second page.
Reverts #516
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
When you reset the rows array with new data from the server, the page will always go back to 1.
What is the new behavior?
The second page will show loaded from the server
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: