reseting page offset on input data change #516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Suppose my current
offset
is 10,limit
is 10 and I have 100 rows to display. Now when I filter data based on some search or something I am left with 10 or 15 rows. Thetotal
count in footer is updated as expected but all rows are disappeared as theoffset
is not being reset.issue: #515
What is the new behaviour?
Reset offset to zero(page 1) whenever
rows
input is changed.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
One other approach can be checking if current offset have data to display and then reset offset accordingly.
Basically something like:
but I think the current PR implementation provides more consistent behaviour.