Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[selectAllRowsOnPage] is broken. #1725 : Bug Fix #1809

Merged
merged 3 commits into from
Apr 6, 2020

Conversation

sacgrover
Copy link
Contributor

@sacgrover sacgrover commented Jan 13, 2020

A check was missing in the code and after adding it everything working fine.

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

#1725
#1817
#1812

What is the new behavior?

Functionality is working as expected.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

A check was missing in the code and after adding it everything working fine.
@sacgrover
Copy link
Contributor Author

@marjan-georgiev

Could you please review this merge request?

@sbharam
Copy link

sbharam commented Feb 4, 2020

We are also facing same issue. Need this fix.
@marjan-georgiev could you pls review & merge this PR. It would be helpful.

@sacgrover
Copy link
Contributor Author

@marjan-georgiev Could you please check this request? If it doesn't look good to you then we can close it.

@sacgrover
Copy link
Contributor Author

@Hypercubed

@Hypercubed Hypercubed self-assigned this Apr 6, 2020
@Hypercubed Hypercubed merged commit 9b14c64 into swimlane:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants