Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when using cellClass as string. #1817

Closed
danielbom opened this issue Jan 29, 2020 · 0 comments
Closed

Bug when using cellClass as string. #1817

danielbom opened this issue Jan 29, 2020 · 0 comments
Assignees

Comments

@danielbom
Copy link

I'm submitting a...

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
When apply cellClass as string, the classes names merges.
Ex: colums: [{ prop: 'name', name: 'Name', cellClass: 'cell-primary' }]
In HTML the classes become: 'datatable-body-cellcell-primary', and not 'datatable-body-cell.cell-primary'.
I solved my problem adding a whitespace in cellClass (cellClass: ' cell-primary')

Expected behavior
Expects the cellClass not need a 'hack' to work with strings. This seems simple to solve and seems not has side effect.

Reproduction of the problem
I'm not have time and I solved my problem.

What is the motivation / use case for changing the behavior?
It's a simple problem which can cause confusion and problems for any user.

  • Table version: 16.0.3

  • Angular version: 8.1.3

  • Browser: Chrome

  • Language: TypeScript 3.4.5

sacgrover added a commit to sacgrover/ngx-datatable that referenced this issue Feb 4, 2020
@Hypercubed Hypercubed self-assigned this Apr 6, 2020
talandis pushed a commit to talandis/ngx-datatable that referenced this issue Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants