Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tags from suites should be inherited #1015

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

plemarquand
Copy link
Contributor

Tags defined on swift-testing suites are meant to be inherited by child suites/tests. VS Code doesn't apply this inheritance automatically, so we must set a suite's tags on its children ourselves.

Issue: #1014

Tags defined on swift-testing suites are meant to be inherited by child
suites/tests. VS Code doesn't apply this inheritance automatically, so
we must set a suite's tags on its children ourselves.

Issue: swiftlang#1014
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plemarquand plemarquand merged commit d801d41 into swiftlang:main Aug 19, 2024
7 of 8 checks passed
@plemarquand plemarquand deleted the test-tag-inheritance branch August 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants