Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests in suites marked with swift-testing tag are filtered from Test Explorer #1014

Closed
plemarquand opened this issue Aug 16, 2024 · 1 comment
Closed

Tests in suites marked with swift-testing tag are filtered from Test Explorer #1014

plemarquand opened this issue Aug 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@plemarquand
Copy link
Contributor

If you add a tag to a suite and filter the test explorer by that tag, the suite appears in the list but its child tests/suites do not. If a suite has a tag, all children of that suite should inherit it as well.

The swift-testing documentation on tags states: "If any tags are applied to a test suite, then all tests in that suite inherit those tags."

Running the suite while in the test explorer filtered view VS Code runs no tests, because no tests match that tag, only the suite.

See attached screenshot:

Screenshot 2024-08-16 at 2 56 01 PM
@plemarquand plemarquand added the bug Something isn't working label Aug 16, 2024
@plemarquand plemarquand self-assigned this Aug 16, 2024
plemarquand added a commit to plemarquand/vscode-swift that referenced this issue Aug 16, 2024
@plemarquand
Test tags from suites should be inherited
c2e6963 
Tags defined on swift-testing suites are meant to be inherited by child
suites/tests. VS Code doesn't apply this inheritance automatically, so
we must set a suite's tags on its children ourselves.

Issue: swiftlang#1014
@plemarquand plemarquand mentioned this issue Aug 16, 2024
Merged
plemarquand added a commit that referenced this issue Aug 19, 2024
@plemarquand
Test tags from suites should be inherited (#1015)
d801d41 
Tags defined on swift-testing suites are meant to be inherited by child
suites/tests. VS Code doesn't apply this inheritance automatically, so
we must set a suite's tags on its children ourselves.

Issue: #1014
@plemarquand plemarquand added the needs verification Issue has been fixed, but requires verification before closing label Aug 20, 2024
@award999 award999 assigned award999 and unassigned plemarquand Aug 27, 2024
@award999
Copy link
Contributor

Verified with d6c91dd

@award999 award999 removed the needs verification Issue has been fixed, but requires verification before closing label Aug 27, 2024
@award999 award999 removed their assignment Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plemarquand @award999