[stdlib] Add arg labels to _expectEnd #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
moiseev
reviewed
Oct 26, 2016
| @@ -1694,8 +1694,7 @@ internal func _arrayOutOfPlaceReplace<B, C>( | |||
| /// A _debugPrecondition check that `i` has exactly reached the end of | |||
| /// `s`. This test is never used to ensure memory safety; that is | |||
| /// always guaranteed by measuring `s` once and re-using that value. | |||
| // FIXME(ABI)#15 : add argument labels. | |||
| internal func _expectEnd<C : Collection>(_ i: C.Index, _ s: C) { | |||
| internal func _expectEnd<C : Collection>(of s: C, is i: C.Index) { | |||
There was a problem hiding this comment.
extension Collection {
internal func _expectEnd(at: Self.Index) { ... }
}maybe?
There was a problem hiding this comment.
I thought about doing that, but it didn't sit right with me. assert-like things seem to feel a bit better as stand-alone functions than methods. Not sure I'm being rational about that tho.
airspeedswift
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving ABI FIXME #15