Remove conditional compilation of tvOS #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrose-apple Could you take a look? |
|
Looks good to me. Thanks! |
gribozavr
added a commit
that referenced
this pull request
Dec 1, 2015
Remove conditional compilation of tvOS
airspeedswift
added a commit
that referenced
this pull request
Oct 27, 2016
[stdlib] Add arg labels to _expectEnd (ABI FIXME #15)
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Jan 11, 2018
* Restore support for 32-bit platforms On 32-bit platforms, add an extra 32-bit word to both _StringObject and _StringGuts for padding and metadata bit storage. Padding _StringObject rather than adding two extra words to _StringGuts makes for unattractively discontiguous inline storage. However, _StringObject needs 2 more metadata bits than are available in a 32-bit BridgeObject; shoving an extra word in there was easier than a full code reorganization. To make use of all this luxurious extra space, on 32-bit platforms, _StringGuts._otherBits always contains the count for contiguous strings, while the new _StringGuts._extraBits stored property contains the start address. This makes extracting an unmanaged view a trivial operation. * [runtime] SwiftObject, SwiftValue: Simplify -description implementation Previously, these classes implemented -description and -debugDescription by 1) calling _getSummary in the stdlib to get the Swift String description corresponding to the value, and then 2) calling _convertStringToNSString in the Foundation overlay to convert the resulting String into an NSString. To hold the Swift String value between the two calls, SwiftObject defined a dummy C++ struct whose layout is supposed match that of Swift Strings. Instead of updating this struct to the new String representation, this commit collapses the two stages above into a single call into a new generic function, _getDescription (defined in the Foundation overlay), which gets rid of this maintenance chore. * [runtime] Reflection: Update String representation to follow stdlib changes * _StringObject: Replace _BridgeObject with AnyObject? on 32-bit platforms Also, don't store any tagged value in _StringObject on 32-bit -- with AnyObject taking up a full word now, we only have 28 bits available (30 tops), which is not enough to store either a count nor a start address. * LibcShims: Adjust _swift_stdlib_print_hex for 32-bit platforms. * [test] Update 32-bit reflection tests Previous (speculative) update missed a couple of offset/size changes. * [test] IRGen/lazy_multi_file.swift: Allow for the possibility of an sret param before self. String is 4 words long on 32 bit platforms, which gets returned via sret on i386. * [test] DebugInfo/self.swift: Don't expect self to be alloca'd first On i386, space for a String gets allocated before the self variable. * _StringGuts: Add _RawBitPattern typealias * _StringGuts: Fix an overlapping access warning * _StringVariant: Remove IndexDistance condition * [runtime] Update mangled symbol
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Jan 18, 2018
* Restore support for 32-bit platforms On 32-bit platforms, add an extra 32-bit word to both _StringObject and _StringGuts for padding and metadata bit storage. Padding _StringObject rather than adding two extra words to _StringGuts makes for unattractively discontiguous inline storage. However, _StringObject needs 2 more metadata bits than are available in a 32-bit BridgeObject; shoving an extra word in there was easier than a full code reorganization. To make use of all this luxurious extra space, on 32-bit platforms, _StringGuts._otherBits always contains the count for contiguous strings, while the new _StringGuts._extraBits stored property contains the start address. This makes extracting an unmanaged view a trivial operation. * [runtime] SwiftObject, SwiftValue: Simplify -description implementation Previously, these classes implemented -description and -debugDescription by 1) calling _getSummary in the stdlib to get the Swift String description corresponding to the value, and then 2) calling _convertStringToNSString in the Foundation overlay to convert the resulting String into an NSString. To hold the Swift String value between the two calls, SwiftObject defined a dummy C++ struct whose layout is supposed match that of Swift Strings. Instead of updating this struct to the new String representation, this commit collapses the two stages above into a single call into a new generic function, _getDescription (defined in the Foundation overlay), which gets rid of this maintenance chore. * [runtime] Reflection: Update String representation to follow stdlib changes * _StringObject: Replace _BridgeObject with AnyObject? on 32-bit platforms Also, don't store any tagged value in _StringObject on 32-bit -- with AnyObject taking up a full word now, we only have 28 bits available (30 tops), which is not enough to store either a count nor a start address. * LibcShims: Adjust _swift_stdlib_print_hex for 32-bit platforms. * [test] Update 32-bit reflection tests Previous (speculative) update missed a couple of offset/size changes. * [test] IRGen/lazy_multi_file.swift: Allow for the possibility of an sret param before self. String is 4 words long on 32 bit platforms, which gets returned via sret on i386. * [test] DebugInfo/self.swift: Don't expect self to be alloca'd first On i386, space for a String gets allocated before the self variable. * _StringGuts: Add _RawBitPattern typealias * _StringGuts: Fix an overlapping access warning * _StringVariant: Remove IndexDistance condition * [runtime] Update mangled symbol
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Port most of libdispatch tests to Linux (31 compile; 21 pass).
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Port most of libdispatch tests to Linux (31 compile; 21 pass). Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
kateinoigakukun
referenced
this pull request
in kateinoigakukun/swift
Nov 16, 2019
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles `hello.swift` on CI. In the future packaging and linking scripts should be moved to this repository, `swiftwasm-sdk` and `swiftwasm-package-sdk` projects probably would be archived when that happens. For now we're pulling the scripts from `swiftwasm-package-sdk` as it is. * Run packaging scripts and smoke test on CI * Make prepare-package.sh executable * Make SymbolLookup.swift compilable for wasm * Use GitHub Actions upload/download steps * Remove packaging steps from ci-*.sh * Move prepare-package.sh to main.yml to avoid clone * Refine formatting in .github/workflows/main.yml
lorentey
pushed a commit
that referenced
this pull request
Dec 11, 2019
kateinoigakukun
referenced
this pull request
in kateinoigakukun/swift
Dec 14, 2019
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles `hello.swift` on CI. In the future packaging and linking scripts should be moved to this repository, `swiftwasm-sdk` and `swiftwasm-package-sdk` projects probably would be archived when that happens. For now we're pulling the scripts from `swiftwasm-package-sdk` as it is. * Run packaging scripts and smoke test on CI * Make prepare-package.sh executable * Make SymbolLookup.swift compilable for wasm * Use GitHub Actions upload/download steps * Remove packaging steps from ci-*.sh * Move prepare-package.sh to main.yml to avoid clone * Refine formatting in .github/workflows/main.yml
kateinoigakukun
referenced
this pull request
in kateinoigakukun/swift
Jan 11, 2020
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles `hello.swift` on CI. In the future packaging and linking scripts should be moved to this repository, `swiftwasm-sdk` and `swiftwasm-package-sdk` projects probably would be archived when that happens. For now we're pulling the scripts from `swiftwasm-package-sdk` as it is. * Run packaging scripts and smoke test on CI * Make prepare-package.sh executable * Make SymbolLookup.swift compilable for wasm * Use GitHub Actions upload/download steps * Remove packaging steps from ci-*.sh * Move prepare-package.sh to main.yml to avoid clone * Refine formatting in .github/workflows/main.yml
kateinoigakukun
referenced
this pull request
in kateinoigakukun/swift
Jan 24, 2020
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles `hello.swift` on CI. In the future packaging and linking scripts should be moved to this repository, `swiftwasm-sdk` and `swiftwasm-package-sdk` projects probably would be archived when that happens. For now we're pulling the scripts from `swiftwasm-package-sdk` as it is. * Run packaging scripts and smoke test on CI * Make prepare-package.sh executable * Make SymbolLookup.swift compilable for wasm * Use GitHub Actions upload/download steps * Remove packaging steps from ci-*.sh * Move prepare-package.sh to main.yml to avoid clone * Refine formatting in .github/workflows/main.yml
MaxDesiatov
referenced
this pull request
in MaxDesiatov/swift
May 1, 2020
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles `hello.swift` on CI. In the future packaging and linking scripts should be moved to this repository, `swiftwasm-sdk` and `swiftwasm-package-sdk` projects probably would be archived when that happens. For now we're pulling the scripts from `swiftwasm-package-sdk` as it is. * Run packaging scripts and smoke test on CI * Make prepare-package.sh executable * Make SymbolLookup.swift compilable for wasm * Use GitHub Actions upload/download steps * Remove packaging steps from ci-*.sh * Move prepare-package.sh to main.yml to avoid clone * Refine formatting in .github/workflows/main.yml
This was referenced Jul 31, 2016
This was referenced Oct 4, 2022
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Apr 28, 2024
correct the location for the ICU packaging rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.