Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoDiff] Remove flaky SR-12650 negative test. #31919

Merged
merged 1 commit into from
May 20, 2020

Conversation

dan-zheng
Copy link
Contributor

@noDerivative parameter mangling was added in #31201, so the negative test is not meaningful.

The test occasionally flaked during CI, so it's better to remove it:

14:20:50 FAIL: Swift(linux-x86_64) :: AutoDiff/compiler_crashers_fixed/sr12650-noderivative-parameter-type-mangling.swift (13232 of 13264)
14:20:50 ******************** TEST 'Swift(linux-x86_64) :: AutoDiff/compiler_crashers_fixed/sr12650-noderivative-parameter-type-mangling.swift' FAILED ********************
14:20:50 Script:
14:20:50 --
14:20:50 : 'RUN: at line 1';   /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test@2/branch-master/buildbot_linux/swift-linux-x86_64/bin/swiftc -target x86_64-unknown-linux-gnu -toolchain-stdlib-rpath  -module-cache-path '/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test@2/branch-master/buildbot_linux/swift-linux-x86_64/swift-test-results/x86_64-unknown-linux-gnu/clang-module-cache' -swift-version 4  -Xfrontend -ignore-module-source-info  -g /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test@2/branch-master/swift/test/AutoDiff/compiler_crashers_fixed/sr12650-noderivative-parameter-type-mangling.swift
14:20:50 --
14:20:50 Exit Code: 254
14:20:50 
14:20:50 Command Output (stderr):
14:20:50 --
14:20:50 
clang-10: error: unable to execute command: Bus error (core dumped)
14:20:50 clang-10: error: linker command failed due to signal (use -v to see invocation)
14:20:50 <unknown>:0: error: link command failed with exit code 254 (use -v to see invocation)

`@noDerivative` parameter mangling was added, so the test is not meaningful.
The test occasionally flaked during CI, so it is better to remove it.
@dan-zheng dan-zheng requested a review from CodaFi May 20, 2020 17:52
@dan-zheng
Copy link
Contributor Author

@swift-ci Please smoke test

@dan-zheng dan-zheng merged commit ffca352 into swiftlang:master May 20, 2020
@dan-zheng dan-zheng deleted the autodiff-testing branch May 20, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant