Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoDiff] Mangle @noDerivative parameters. #31201

Merged
merged 2 commits into from
Apr 22, 2020
Merged

[AutoDiff] Mangle @noDerivative parameters. #31201

merged 2 commits into from
Apr 22, 2020

Conversation

dan-zheng
Copy link
Contributor

Mangle @noDerivative parameters to fix type reconstruction errors.
Resolves SR-12650. The new mangling is purely additive.

Example:

$ swift-demangle --expand sS3fIedgyywd_D
Demangling for $sS3fIedgyywd_D
kind=Global
  kind=TypeMangling
    kind=Type
      kind=ImplFunctionType
        kind=ImplEscaping
        kind=ImplDifferentiable
        kind=ImplConvention, text="@callee_guaranteed"
        kind=ImplParameter
          kind=ImplConvention, text="@unowned"
          kind=ImplDifferentiability, text=""                     < new
          kind=Type
            kind=Structure
              kind=Module, text="Swift"
              kind=Identifier, text="Float"
        kind=ImplParameter
          kind=ImplConvention, text="@unowned"
          kind=ImplDifferentiability, text="@noDerivative"        < new
          kind=Type
            kind=Structure
              kind=Module, text="Swift"
              kind=Identifier, text="Float"
        kind=ImplResult
          kind=ImplConvention, text="@unowned"
          kind=Type
            kind=Structure
              kind=Module, text="Swift"
              kind=Identifier, text="Float"
$sS3fIedgyywd_D ---> @escaping @differentiable @callee_guaranteed (@unowned Swift.Float, @unowned @noDerivative Swift.Float) -> (@unowned Swift.Float)

When differentiation supports multiple result indices (TF-1250) and @noDerivative
results are added, we can reuse some of this mangling support.

@dan-zheng
[AutoDiff] Mangle @noDerivative parameters.
d164a49 
Mangle `@noDerivative` parameters to fix type reconstruction errors.
Resolves SR-12650. The new mangling is purely additive.

When differentiation supports multiple result indices and `@noDerivative`
results are added, we can reuse some of this mangling support.
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

@dan-zheng dan-zheng mentioned this pull request Apr 22, 2020
Closed
marcrasi
marcrasi approved these changes Apr 22, 2020
View reviewed changes
lib/Demangling/NodePrinter.cpp Outdated Show resolved Hide resolved
@dan-zheng
Fix typo.
cfc2cc7 
`Cihldren` -> `Children`
@dan-zheng
Copy link
Contributor Author

@swift-ci Please smoke test

@dan-zheng dan-zheng merged commit 8357c18 into swiftlang:master Apr 22, 2020
@dan-zheng dan-zheng deleted the noderivative-param-mangling branch April 22, 2020 19:38
@dan-zheng dan-zheng mentioned this pull request May 20, 2020
Merged
rxwei pushed a commit to rxwei/swift that referenced this pull request Jun 3, 2020
@dan-zheng @rxwei
[AutoDiff] Mangle @noDerivative parameters. (swiftlang#31201)
a8a05bc 
Mangle `@noDerivative` parameters to fix type reconstruction errors.
Resolves SR-12650. The new mangling is non-breaking.

When differentiation supports multiple result indices and `@noDerivative`
results are added, we can reuse some of this mangling support.
@dan-zheng dan-zheng mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

@marcrasi marcrasi marcrasi approved these changes

@slavapestov slavapestov Awaiting requested review from slavapestov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-zheng @rxwei @marcrasi