Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST: Check return value of ProtocolConformance::getTypeWitness() #11076

Merged
merged 1 commit into from
Jul 20, 2017
Merged

AST: Check return value of ProtocolConformance::getTypeWitness() #11076

merged 1 commit into from
Jul 20, 2017

Commits on Jul 20, 2017

  1. AST: Check return value of ProtocolConformance::getTypeWitness() 

    This method returns an empty Type if the conformance is currently
being checked. The other caller of this method in the
GenericSignatureBuilder checked the return value and bailed out,
but one place did not.

This is probably not the right long-term fix, but it matches what
the other caller of getTypeWitness() does in this file.

I don't have a reduced test case either; the repro involves
building a specific revision of the standard library with a patch
applied. However, the fix can't really do any harm, since passing
an empty Type here quickly crashes.

Fixes <rdar://problem/32296747>, <https://bugs.swift.org/browse/SR-4945>.
    @slavapestov
    slavapestov committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    469d1f7 View commit details
    Browse the repository at this point in the history