AST: Check return value of ProtocolConformance::getTypeWitness() #11076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method returns an empty Type if the conformance is currently being checked. The other caller of this method in the GenericSignatureBuilder checked the return value and bailed out, but one place did not. This is probably not the right long-term fix, but it matches what the other caller of getTypeWitness() does in this file. I don't have a reduced test case either; the repro involves building a specific revision of the standard library with a patch applied. However, the fix can't really do any harm, since passing an empty Type here quickly crashes. Fixes <rdar://problem/32296747>, <https://bugs.swift.org/browse/SR-4945>.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method returns an empty Type if the conformance is currently
being checked. The other caller of this method in the
GenericSignatureBuilder checked the return value and bailed out,
but one place did not.
This is probably not the right long-term fix, but it matches what
the other caller of getTypeWitness() does in this file.
I don't have a reduced test case either; the repro involves
building a specific revision of the standard library with a patch
applied. However, the fix can't really do any harm, since passing
an empty Type here quickly crashes.
Fixes rdar://problem/32296747, https://bugs.swift.org/browse/SR-4945.