Support building this repo for more platforms, by checking the build triple #500
Conversation
|
@franklinsch, now that this passed the CI on the linked compiler pull, looking for review so I can get this in before the upcoming 5.9 branch. Please don't merge though, as all 11 pulls will have to be merged together. |
|
Removed the runpath change since the Swift devs want to take a different approach, leaving only these build script modifications I had come up with. One last CI run and this can go in, @ethan-kusters. |
finagolfin
changed the title
|
@QuietMisdreavus, would you run the CI and review? |
|
@swift-ci please test |
|
@buttaface is there a recent CI run in the Swift repo that links this change and successfully produces a toolchain? I'm seeing swiftlang/swift#63782 but since that was declined I'd rather see this successfully build with the |
|
Not with this specific pull, no, only the prior version that also changed the runpaths. You'll have to build this one again if you want to check that. |
…triple This is rather than checking the host system, plus removed unnecessary regex checking.
|
@bnbarham, would you kick off a toolchain build of this pull on the main compiler repo, to assuage Ethan's concerns? |
|
@ethan-kusters, a full CI build of this pull passed now, should be okay to go in. |
There was a problem hiding this comment.
-
Successful macOS toolchain build here: https://ci.swift.org/job/swift-PR-toolchain-macos/691/
-
Successful Linux toolchain build here: https://ci.swift.org/job/swift-PR-toolchain-Linux/440/
Looks great. Thank you @finagolfin!
|
@swift-ci please test |
|
@ethan-kusters, please merge if okay. |
Summary
This is needed for swiftlang/swift#63782, which changes the Unix toolchain to look for libraries in architecture-specific directories.I
alsoupdated some checks for the runtime target triple, rather than checking the host system, and removed unnecessary regex checking.Alex had asked for the regex removals in swiftlang/sourcekit-lsp#717, so I brought them over here too.
Dependencies
The linked compiler pull and the various other repo pulls tested there.NoneTesting
Primarily, it should work as before, but I also added an rpath check to swiftlang/swift-integration-tests#113 so that it's checked on every linux CI run from now on.
Checklist
./bin/testscript and it succeededI didn't run the test script because I don't have all the dependencies set up locally- the CI will check that- and there's no doc to update for build script changes AFAIK.