Check the target triple to determine what build flags to apply when building sourcekit-lsp #717
Conversation
finagolfin
force-pushed
the
arch
branch
2 times, most recently
from
53a1e88 to
f527cb6
Compare
|
Made the changes you asked for but don't merge yet, just looking for review until this can be tested on the CI alongside the other pulls. |
|
Let me know when you’d like to run tests for this PR and merge it. |
|
@ahoppen, I've been asking for someone to run all these pulls together on the CI, see comment on linked compiler pull, would be great if you would kick that CI run off. |
|
I triggered PR testing on the main PR. Ping me if you need more testing. |
|
Thanks, looks like I missed installing the local libicu for linux in this new location, will investigate. |
|
@ahoppen, fixed the two issues that cropped up on the CI, ready for another CI run on the linked compiler pull with all 7 of these other pulls. |
…uilding sourcekit-lsp I also replaced unnecessary regex checks.
|
Removed the runpath changes since the Swift devs want to take a different approach, leaving only the build script updates we discussed. One last CI run and this can go in, @ahoppen. |
finagolfin
changed the title
|
Ping @ahoppen, something wrong with getting this in? |
|
Ping @benlangmuir, Alex appears to be busy lately, would you run through CI and merge? |
|
@swift-ci please test |
|
Sorry, I just forgot about it and was indeed busy the last two days. Merging it now. |
This is needed for swiftlang/swift#63782, which changes the Unix toolchain to look for libraries in architecture-specific directories.I
alsoupdated some checks for the runtime target triple, rather than checking the host system, and removed unnecessary regex checking.