Added a matrix of 4 targets for CI builds #70
Conversation
jbangelo
force-pushed
the
jbangeo/pr-build-matrix
branch
from
fdc8883 to
5dac68e
Compare
jbangelo
force-pushed
the
jbangeo/pr-build-matrix
branch
from
5dac68e to
fe5777d
Compare
jbangelo
force-pushed
the
jbangeo/pr-build-matrix
branch
from
9686a11 to
79f25da
Compare
| CARGO_MAKE_RUN_CHECK_FORMAT = true | ||
| RUSTFLAGS="-D warnings" | ||
| sudo apt-get install musl-tools | ||
| sudo ln -s /usr/bin/musl-gcc /usr/bin/musl-g++ |
There was a problem hiding this comment.
This extra step is needed to compiler C++ files with musl. Seems odd that musl-g++ isn't installed by default...
There was a problem hiding this comment.
It is a bit odd, but at least there's precedent, this is what I've used to build musl in the past: https://github.com/emk/rust-musl-builder/blob/master/Dockerfile#L74
| - name: Install LLVM and Clang # required for bindgen on Windows | ||
| uses: KyleMayes/install-llvm-action@v1 | ||
| if: matrix.os == 'windows-2019' | ||
| with: | ||
| version: "10.0" |
There was a problem hiding this comment.
We also need to manually install LLVM/Clang for bindgen to execute correctly on windows...
There was a problem hiding this comment.
Clang and LLVM should already be installed, but the environment vars on GitHub actions are supposedly a mess... so could be that reinstalling with this action just puts the environment in a good state.
| @@ -0,0 +1,25 @@ | |||
| [env] | |||
There was a problem hiding this comment.
I moved this into a dedicated file since cating it together wouldn't work on a Windows shell. Is there a better alternative?
There was a problem hiding this comment.
I think this is fine, I don't think there was a specific reason to keep the makefile.toml inside the ci config
No description provided.