Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite previous decisions #35

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Don't overwrite previous decisions #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
700bb12
feat: propose 10
BobBorges Oct 17, 2024
9e0f513
feat:approve decision
BobBorges Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions docs/decisions/decision-10_no-edit-merged-decisions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Don't edit decision docs that have been decided upon

## Status

Decided

- Decision: accepted


## Context
I noticed in a previous decision (8), there were edits made to the decision 3 document. In this case the edit was sensible and small, but it shouldn't happen IMO -- this opens the door for post-hoc rewriting the rules, and lots of potential confusion.

## Decision
Don't merge any edits to decision documents that already exist in main -- ideally we formally block this in github. Changes to existing decisions should be proposed in a new decision.

## Consequences
Minor edits become tedious, but decision documents are more trustworthy.