Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite previous decisions #35

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Don't overwrite previous decisions #35

merged 2 commits into from
Nov 1, 2024

Conversation

BobBorges
Copy link
Contributor

.

@MansMeg
Copy link
Contributor

MansMeg commented Oct 17, 2024

I think the whole idea with git make this feasible. I changed decision 3 as a consequence of decision 8. I think that is ok. Since we want to be able to change decisions. Thats why we version control them.

@ninpnin
Copy link

ninpnin commented Oct 17, 2024

A decision can only be overwritten by another decision?

@MansMeg
Copy link
Contributor

MansMeg commented Oct 17, 2024

Well. It is a decision to rewrite a previoys decision.

@BobBorges
Copy link
Contributor Author

I think I'm happy so long as no edits can sneak past the review process, and we probably want to not only version control edits, but cross reference decisions somehow, so that if we edit 3 after 8, we also note in 3 that it was revised after 8 and/or in 8, 'this decision includes revision to 3'. Version control is great, but it doesn't necessarily tell us why the decision was edited and I think that the logic behind the decisions we make should also be part of the documentation.

@BobBorges
Copy link
Contributor Author

I've now also proposed decision 11 that amends 3 -- lets see if the convention seems reasonable to the others.

@fredrik1984
Copy link
Contributor

Bob fix this.

@BobBorges BobBorges merged commit ae6030e into main Nov 1, 2024
@BobBorges BobBorges deleted the decision-10 branch November 1, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants