Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/resolver): Use different syntax context for unresolved refs #4436

Merged
merged 95 commits into from
Apr 26, 2022
Merged

feat(es/resolver): Use different syntax context for unresolved refs #4436

merged 95 commits into from
Apr 26, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 25, 2022 •
edited
Loading

Description:

  • We don't need a list of bindings to check if an identifier is unresolved.
  • Checking if an identifier is unresolved is now one CPU instruction.
    • Previously it was one hashmap operation.
  • This PR also improves performance, by removing hashmaps mentioned above.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Apr 25, 2022
kdy1
kdy1 commented Apr 26, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_base --breaking

kdy1
kdy1 commented Apr 26, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common

@kdy1 kdy1 marked this pull request as ready for review April 26, 2022 07:09
@kdy1 kdy1 enabled auto-merge (squash) April 26, 2022 07:09
swc-bot
swc-bot reviewed Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 53610fd into swc-project:main Apr 26, 2022
@kdy1 kdy1 deleted the resolver branch April 26, 2022 07:38
@kdy1
Copy link
Member Author

kdy1 commented Apr 26, 2022

image

These are actual numbers for performance improvements

@kdy1 kdy1 modified the milestones: Planned, v1.2.172 Apr 26, 2022
@bartlomieju bartlomieju mentioned this pull request Apr 26, 2022
Closed
@mischnic mischnic mentioned this pull request Apr 30, 2022
Merged
4 tasks
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.172
Development

Successfully merging this pull request may close these issues.

resolver should use different mark for top level bindings and unresolved identifiers
2 participants
@kdy1 @swc-bot