Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver should use different mark for top level bindings and unresolved identifiers #2956

Closed
kdy1 opened this issue Dec 3, 2021 · 2 comments · Fixed by #4436
Closed

resolver should use different mark for top level bindings and unresolved identifiers #2956

kdy1 opened this issue Dec 3, 2021 · 2 comments · Fixed by #4436
Milestone

Comments

@kdy1
Copy link
Member

kdy1 commented Dec 3, 2021

No description provided.

@dsherret
Copy link
Contributor

dsherret commented Dec 9, 2021

I started working on #2996 and I think it would be better to fix that along with doing this change. Basically there needs to be a way to express:

import { Name } from "./something";

...as being a module level binding that's not accessible within the module. I should work on other things right now, but this is a source of some bugs.

@kdy1 kdy1 modified the milestones: v1.2.119, v1.2.120, v1.2.121 Dec 10, 2021
@kdy1 kdy1 modified the milestones: v1.2.121, v1.2.122, v1.2.123, v1.2.124 Dec 19, 2021
@kdy1 kdy1 modified the milestones: v1.2.128, v1.2.129 Jan 11, 2022
@kdy1 kdy1 modified the milestones: v1.2.129, v1.2.130, v1.2.131 Jan 13, 2022
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 16, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants