Reload swaybar/swaybg on config reload.

[mikkeloscar]

This works by tracking the pids of the child processes in the related
output container and terminating the processes and spawning new ones on
a config reload.

Should solve: #347

[mikkeloscar]

This has one problem where the windows will cover the bar after a reload until you do something to rearrange them, i.e. spawn a new window. I suspect this also happens on startup but since you don't have any windows open at that point you won't see it.

Any ideas how to update the layout correctly when spawning the bar after a reload?

[ddevault]

@mikkeloscar just run arrange_windows(&root_container, -1, -1) to force a rearrange of the entire compositor.

[mikkeloscar]

Hmm, that is called in cmd_reload after a new bar is spawned.

I just tried on the master branch and if you spawn a window and then spawn a swaybar manually the same thing happens (it spawns behind the window).

I did a bisect of master and I think this issue was introduced in ed730db

[mikkeloscar]

Yes, this problem doesn't happen if I revert ed730db

@sce thoughts?

[sce]

Hmm... I'm looking in to it now.

[ddevault]

This struct is getting kind of out of control. Half of the properties only apply to a certain kind of swayc (i.e. C_OUTPUT, in this case). Can we figure out a good way of splitting these up?

[mikkeloscar]

I don't know if this is the best approach, but what about adding a void* field to swayc_t which can be used for whatever, in this case it would point to:

struct swayc_output {
    list_t *bar_pids;
    pid_t bg_pid;
    // other fields unique to a swayc_t of type C_OUTPUT
};

[ddevault]

How about a union of pointers to type-specific data?

[mikkeloscar]

Yeah that's probably better so we don't need to cast all over the place.