Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swaybar doesn't handle new configuration at runtime. #347

Closed
mikkeloscar opened this issue Dec 17, 2015 · 5 comments
Closed

swaybar doesn't handle new configuration at runtime. #347

mikkeloscar opened this issue Dec 17, 2015 · 5 comments

Comments

@mikkeloscar
Copy link
Collaborator

If you edit the config and reload it while sway is running the bar doesn't update with the new bar configuration.
@ddevault
Copy link
Contributor

Related - you can't change your wallpaper at runtime. We need to kill and restart the sway subprocesses.

@mikkeloscar
Copy link
Collaborator Author

If we store the pids of swaybar and swaybg somewhere then it would be easy to kill and restart them on reload. My idea would be to store them in an output container since each swaybg/swaybar process "belong" to a single output as far as I can tell. What do you think of this approach?

@ddevault
Copy link
Contributor

I like that approach.

@mikkeloscar
Copy link
Collaborator Author

Ok, cool, I will try to work on that tomorrow then.

mikkeloscar added a commit to mikkeloscar/sway that referenced this issue Dec 18, 2015
@mikkeloscar
Reload swaybar/swaybg on config reload.
2ea2fb0 
This works by tracking the pids of the child processes in the related
output container and terminating the processes and spawning new ones on
a config reload.

Should solve: swaywm#347
mikkeloscar added a commit to mikkeloscar/sway that referenced this issue Dec 18, 2015
@mikkeloscar
Reload swaybar/swaybg on config reload.
24fbcbc 
This works by tracking the pids of the child processes in the related
output container and terminating the processes and spawning new ones on
a config reload.

Should solve: swaywm#347
@mikkeloscar mikkeloscar mentioned this issue Dec 18, 2015
Merged
mikkeloscar added a commit to mikkeloscar/sway that referenced this issue Dec 18, 2015
@mikkeloscar
Reload swaybar/swaybg on config reload.
ede27ea 
This works by tracking the pids of the child processes in the related
output container and terminating the processes and spawning new ones on
a config reload.

Should solve: swaywm#347
@mikkeloscar
Copy link
Collaborator Author

Fixed in #358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikkeloscar @ddevault