-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --spa-index option #515
Add --spa-index option #515
Conversation
Good job! Now I wonder if |
Thanks. I'm aware of the PR, but those changes aren't yet released and I needed this feature sooner rather than later. Hmm, your suggestion is certainly more intuitive. But if you want to have an SPA that is not at the root of your site then having the flexibility of my implementation would be useful. |
That is something of an edge case though. I can change it to be how you suggested if you like. |
Well, I don't have a strong opinion on this because I don't use SPAs! I think we need a second opinion @svenstaro . |
Is the behavior of the current |
@svenstaro I have just tried with the latest version and unless I'm missing something the problem is the same. Is there a specific change that you expected to resolve this? |
dec6959
to
6dfe4d1
Compare
@sinking-point can you fix the CI thing real quick? It's just a small formatting issue. |
@svenstaro sure, should be fine now. |
Clippy doesn't seem happy yet. :) |
@sinking-point Can you fix this real quick? |
@svenstaro my bad, I didn't realise there was a linter to contend with. Hopefully sorted now. |
Cool, merging as is but I'll likely make some more ergonomics changes. |
Perfect, thanks for merging. |
Closes #474