-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named file service #2135
Named file service #2135
Conversation
Neat, I like this feature. Definitely would like an example of it in use, maybe on the docs for |
@robjtede Okay, is the implementation fine? |
Looks like it yeah. We'll see for certain with a test of success case response and error case like missing file. |
Would it make sense to implement |
Sure, if it can fit into |
… into named-file-service
Can you rebase this to it merged? I think this is a neat little service that I'd like to see go to mainline. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks ! |
PR Type
Feature
Closes #2115