Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always set draggable through setAttribute to avoid weird behavior #12649

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #12643

Very weird behaviour from the draggable setter...if you set element.draggable="false" it will actually set draggable to true (the boolean).

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: d4d7c14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 32c4e47 into sveltejs:main Jul 29, 2024
7 of 9 checks passed
@Serator
Copy link

Serator commented Jul 30, 2024

Hi @paoloricciuti. https://github.com/sveltejs/svelte/pull/12649/files#diff-87ec8cbb1aa898b9a6bc0e9dde2e355df357844becd562b80386d0bf4713b57fR344-R345 - there are other HTMLElement properties. Here's a possibly incomplete list:

Either way, new properties / attributes will be added over time.

Reproduction link

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: draggable="false" gets rendered as draggable="true" when using <svelte:element>
4 participants