fix: bump all svelte related dependencies #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndom91
commented
Sep 4, 2024
| @@ -3,7 +3,7 @@ import { vitePreprocess } from '@sveltejs/vite-plugin-svelte'; | |||
|
|
|||
| /** @type {import('@sveltejs/kit').Config} */ | |||
| const config = { | |||
| preprocess: vitePreprocess(), | |||
| preprocess: vitePreprocess({ script: true }), | |||
There was a problem hiding this comment.
Required in vite-plugin-svelte@4.0.0+ in order to use enums in .svelte files (Source)
ndom91
changed the title
ndom91
force-pushed
the
ndom91/bump-svelte-deps
branch
from
4351d3b
to
782eb95
Compare
|
there's some lint stuff to fix, otherwise lets do it |
krlvi
approved these changes
Sep 6, 2024
ndom91
force-pushed
the
ndom91/bump-svelte-deps
branch
from
dd48b1b
to
e5079de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
🧢 Changes
pnpm-workspace.ymlsvelte*packages to their latest versionscontext="module"deprecated in favor ofmodule(Source), updated all instances of that here📓 Notes from Changelog reading
<svelte:component />is no longer necessary for dynamic components. All components are dynamic by default now (Source). No changes made here yet atm=": https://github.com/sveltejs/svelte/pull/12614/filessetAttributeto avoid weird behavior sveltejs/svelte#12649