Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade eslint to v9 #11108

Merged
merged 15 commits into from
Apr 10, 2024
Merged

chore: upgrade eslint to v9 #11108

merged 15 commits into from
Apr 10, 2024

Conversation

jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Apr 10, 2024

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: 08c7863

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

- **/*.js.flow
- **/build/**
- **/config/**
- **/dist/**
- **/npm/**
- **/playgrounds/sandbox/**
- **/playwright*/**
package.json Outdated Show resolved Hide resolved
@jrmajor jrmajor requested a review from benmccann April 10, 2024 19:56
package.json Outdated Show resolved Hide resolved
@vane
Copy link

vane commented Apr 14, 2024

I think it broke typescript support because of this typescript-eslint issue
typescript-eslint/typescript-eslint#8211

@benmccann
Copy link
Member

That thread said it should work fine besides give you a peer dependency warning. Are you encountering a specific issue with it?

@vane
Copy link

vane commented Apr 14, 2024

That thread said it should work fine besides give you a peer dependency warning. Are you encountering a specific issue with it?

It indeed gives warning after I bumbed from 8.57.0 to 9.0.0

on freshly created app with 9.0.0 npm install fails with error

# npm resolution error report

While resolving: typescript-eslint@7.6.0
Found: eslint@9.0.0
node_modules/eslint
  dev eslint@"^9.0.0" from the root project
  peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.0
  node_modules/@eslint-community/eslint-utils
    @eslint-community/eslint-utils@"^4.2.0" from eslint@9.0.0
    @eslint-community/eslint-utils@"^4.4.0" from eslint-plugin-svelte@2.37.0
    node_modules/eslint-plugin-svelte
      dev eslint-plugin-svelte@"^2.36.0" from the root project
    @eslint-community/eslint-utils@"^4.4.0" from @typescript-eslint/utils@7.6.0
    node_modules/typescript-eslint/node_modules/@typescript-eslint/utils
      @typescript-eslint/utils@"7.6.0" from typescript-eslint@7.6.0
      node_modules/typescript-eslint
        dev typescript-eslint@"^7.6.0" from the root project
      @typescript-eslint/utils@"7.6.0" from @typescript-eslint/eslint-plugin@7.6.0
      node_modules/typescript-eslint/node_modules/@typescript-eslint/eslint-plugin
        @typescript-eslint/eslint-plugin@"7.6.0" from typescript-eslint@7.6.0
        node_modules/typescript-eslint
          dev typescript-eslint@"^7.6.0" from the root project
      @typescript-eslint/utils@"7.6.0" from @typescript-eslint/type-utils@7.6.0
      node_modules/typescript-eslint/node_modules/@typescript-eslint/eslint-plugin/node_modules/@typescript-eslint/type-utils
        @typescript-eslint/type-utils@"7.6.0" from @typescript-eslint/eslint-plugin@7.6.0
        node_modules/typescript-eslint/node_modules/@typescript-eslint/eslint-plugin
          @typescript-eslint/eslint-plugin@"7.6.0" from typescript-eslint@7.6.0
          node_modules/typescript-eslint
            dev typescript-eslint@"^7.6.0" from the root project
  peer eslint@">=6.0.0" from eslint-compat-utils@0.5.0
  node_modules/eslint-compat-utils
    eslint-compat-utils@"^0.5.0" from eslint-plugin-svelte@2.37.0
    node_modules/eslint-plugin-svelte
      dev eslint-plugin-svelte@"^2.36.0" from the root project
  peer eslint@">=7.0.0" from eslint-config-prettier@9.1.0
  node_modules/eslint-config-prettier
    dev eslint-config-prettier@"^9.1.0" from the root project
  peer eslint@"^7.0.0 || ^8.0.0-0 || ^9.0.0-0" from eslint-plugin-svelte@2.37.0
  node_modules/eslint-plugin-svelte
    dev eslint-plugin-svelte@"^2.36.0" from the root project

Could not resolve dependency:
peer eslint@"^8.56.0" from typescript-eslint@7.6.0
node_modules/typescript-eslint
  dev typescript-eslint@"^7.6.0" from the root project

Conflicting peer dependency: eslint@8.57.0
node_modules/eslint
  peer eslint@"^8.56.0" from typescript-eslint@7.6.0
  node_modules/typescript-eslint
    dev typescript-eslint@"^7.6.0" from the root project

Fix the upstream dependency conflict, or retry
this command with --force or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.

@benmccann
Copy link
Member

If you're talking about a freshly created app, you're posting on the wrong PR and in the wrong repository. You'd be talking about the create-svelte project that lives in the SvelteKit repository and was rolled back to eslint 8 earlier today

This PR only affects people contributing to Svelte itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants