Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: require eslint v9 and switch to flat config #31

Merged
merged 10 commits into from
Apr 10, 2024

Conversation

jrmajor
Copy link

@jrmajor jrmajor commented Apr 8, 2024

No description provided.

@benmccann
Copy link
Member

@jrmajor I see that this PR is currently marked as a draft. GitHub doesn't notify when a PR is goes from draft to ready for review, so please ping me when you're ready for me to take a look and I will review it

@jrmajor jrmajor marked this pull request as ready for review April 10, 2024 12:08
@jrmajor
Copy link
Author

jrmajor commented Apr 10, 2024

@benmccann Ready for review. Please approve the workflow run in sveltejs/svelte#11108 to make sure that it works in the main Svelte repo, and read #32 before releasing a new version. FYI, typescript-eslint doesn't officially support ESLint v9 (typescript-eslint/typescript-eslint#8211), but it seems to work OK, so I don't think we need to wait for official support.

@benmccann
Copy link
Member

Something else I was interested in trying was checking for promise-related errors. I just noticed in another project that TypeScript doesn't catch these types of errors. It should probably be another PR and isn't related to this change at all, but I thought I'd mention it just in case you were interested in working on it at all:

https://github.com/immich-app/immich/blob/7f504ec5fc6a300ec5265433a392f74db18c8e66/web/.eslintrc.cjs#L54

index.js Outdated Show resolved Hide resolved
@benmccann benmccann merged commit de73b59 into sveltejs:master Apr 10, 2024
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
@jrmajor jrmajor deleted the eslint-9 branch April 10, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants