Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent unhandled rejections when loading page modules #4732

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #3978. Even though the failure to load modules following a redeploy (which causes some filenames to be changed) was being dealt with (by causing the page to reload), rejections weren't being handled immediately before, when we preload modules to avoid waterfall.

This is a tricky thing to add a test for, but I verified that with this change the unhandledrejection event no longer happens, which should clean up Sentry logs etc.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2022

🦋 Changeset detected

Latest commit: 83dddcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghostdevv
Copy link
Member

Is there anything blocking this being merged? 🙏

@Rich-Harris Rich-Harris merged commit 0c38bd3 into master May 13, 2022
@Rich-Harris Rich-Harris deleted the gh-3978 branch May 13, 2022 14:53
@Rich-Harris
Copy link
Member Author

nope, nothing blocking except me being in a place with bad wifi for the last couple of weeks — still playing catch-up!

@ghostdevv
Copy link
Member

@Rich-Harris yikes! no worries tysm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to fetch dynamically imported module
3 participants