Skip to content

Commit

Permalink
prevent unhandled rejections when loading page modules - fixes #3978 (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
Rich-Harris authored May 13, 2022
1 parent fc3005e commit 0c38bd3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/silver-elephants-attack.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Prevent unhandled rejections when loading page modules
6 changes: 4 additions & 2 deletions packages/kit/src/runtime/client/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -612,8 +612,10 @@ export function create_client({ target, session, base, trailing_slash }) {
/** @type {Error | null} */
let error = null;

// preload modules
a.forEach((loader) => loader());
// preload modules to avoid waterfall, but handle rejections
// so they don't get reported to Sentry et al (we don't need
// to act on the failures at this point)
a.forEach((loader) => loader().catch(() => {}));

load: for (let i = 0; i < a.length; i += 1) {
/** @type {import('./types').BranchNode | undefined} */
Expand Down

0 comments on commit 0c38bd3

Please sign in to comment.