Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove default <meta name="description"> #4686

Merged
merged 4 commits into from
Apr 22, 2022
Merged

remove default <meta name="description"> #4686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
292b92d
remove default <meta name="description">
Rich-Harris Apr 21, 2022
ee9ffb2
add meta description to demo app
Rich-Harris Apr 21, 2022
3667e0f
add descriptions everywhere
Rich-Harris Apr 22, 2022
c1a8e93
Update .changeset/stupid-owls-provide.md
Rich-Harris Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-owls-provide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-svelte': patch
---

Remove default <meta name="description"> and add separate descriptions to each page
1 change: 0 additions & 1 deletion packages/create-svelte/templates/default/src/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="description" content="Svelte demo app" />
<link rel="icon" href="%svelte.assets%/favicon.png" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
%svelte.head%
Expand Down
1 change: 1 addition & 0 deletions packages/create-svelte/templates/default/src/routes/about.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

<svelte:head>
<title>About</title>
<meta name="description" content="About this app" />
</svelte:head>

<div class="content">
Expand Down
1 change: 1 addition & 0 deletions packages/create-svelte/templates/default/src/routes/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

<svelte:head>
<title>Home</title>
<meta name="description" content="Svelte demo app" />
</svelte:head>

<section>
Expand Down
1 change: 1 addition & 0 deletions packages/create-svelte/templates/default/src/routes/todos/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

<svelte:head>
<title>Todos</title>
<meta name="description" content="A todo list app" />
</svelte:head>

<div class="todos">
Expand Down
1 change: 0 additions & 1 deletion packages/create-svelte/templates/skeleton/src/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="description" content="" />
<link rel="icon" href="%svelte.assets%/favicon.png" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
%svelte.head%
Expand Down