Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default <meta name="description"> #4686

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

The project templates include a default <meta name="description">, which is well-intentioned (you need one to get a good lighthouse score, etc) but ultimately counterproductive since it takes precedence over ones in <svelte:head>

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2022

🦋 Changeset detected

Latest commit: c1a8e93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris changed the title remove default <meta name="description"> remove default <meta name="description"> Apr 21, 2022
@Conduitry
Copy link
Member

Do we want to add one to the root <svelte:head> in our demo apps, or at least the non-skeleton app?

@Rich-Harris
Copy link
Member Author

Yeah, good point — we already have a <title> in the demo app, so it makes sense for <meta name="description"> to live there too

@Conduitry
Copy link
Member

I had meant to __layout.svelte (not index.svelte) - which I think makes more sense. The only reason I'd see to add it to the root route alone is if we also add it to the other ones and are using it to demonstrate how it can be different on different routes but don't want to get too fancy with $page.stuff.

@Rich-Harris
Copy link
Member Author

Am in two minds about that. It's definitely simpler, but reusing descriptions for multiple pages is discouraged by SEO-heads. Short of faffing about with stuff (which feels out of scope for this), I think adding them to every page is probably the better choice

Co-authored-by: Conduitry <git@chor.date>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants