Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typecheck svelte files in tests #1319

Merged
merged 8 commits into from
May 6, 2021
Merged

typecheck svelte files in tests #1319

merged 8 commits into from
May 6, 2021

Conversation

Rich-Harris
Copy link
Member

Adds svelte-check to the check script in packages/kit, which will hopefully help us catch more type errors early (#1316 (comment)).

This doesn't actually fix any of the surfaced errors, but it's low-hanging fruit if anyone wants to work on that

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris
Copy link
Member Author

Made two changes to types:

  • Added an internal NormalizedLoadOutput that mirrors the public LoadOutput, and changed LoadOutput to allow string | Error for loaded.error. An alternative would be to only allow Error
  • Referenced Vite/Svelte types inside the Kit types. This means that people only need to reference Kit types in their own apps

@Rich-Harris Rich-Harris marked this pull request as ready for review May 6, 2021 14:33
@Rich-Harris Rich-Harris merged commit f5e626d into master May 6, 2021
@Rich-Harris Rich-Harris deleted the typecheck-svelte-files branch May 6, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants