Add prerendering to $app/env typings
#1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes TypeScript stop yelling at you if you use `prerendering` from `src/hooks.ts` or wherever.
|
Thanks! It should have a changeset, yes, because that's what triggers the release workflow |
Okay, done! I think! |
|
Is there anything we could have done to catch this error like type checking the tests or examples? It seems like we've had a few reports of issues like this and I'd like to avoid this keep happening if possible |
5 tasks
|
Thanks @TravisSpomer
opened a draft PR for that: #1319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes TypeScript stop yelling at you if you use
prerenderingfromsrc/hooks.tsor wherever.Since this doesn't affect anything at runtime I wasn't sure if it should have a changeset from
pnpx changeset; should I add one?